chore(db_engine_specs): Refactor get_index

[john-bodley]

SUMMARY

Rather than having a normalize_indexes method for normalizing the response of the DB-API get_indexes function, the DB engine spec should provide a more flexible utility method named get_indexes—akin to get_table_names, get_column_names, etc. with access to the database et al. objects and can be overridden.

The motivation for the change is at Airbnb for Trino we have both Iceberg and Hive backed tables where the Trino DB-API get_indexes method returns an empty list for Iceberg backed tables. Providing a get_indexes method within the DB engine spec allows us to easily add custom logic to handle both scenarios within our derived engine spec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI. Added unit tests.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

Same logic as before just a cleaner presentation including adding keyword arguments, i.e., previously it wasn't apparent in cls._partition_query(table_name, database, 1, part_fields) what 1 and part_fields meant.

[codecov]

Codecov Report

Merging #23656 (db55c7b) into master (976e333) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head db55c7b differs from pull request most recent head ebd79e5. Consider uploading reports for the commit ebd79e5 to get more accurate results

@@           Coverage Diff           @@
##           master   #23656   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        1920     1920           
  Lines       73984    73990    +6     
  Branches     8092     8092           
=======================================
+ Hits        50374    50379    +5     
- Misses      21539    21540    +1     
  Partials     2071     2071           

Flag	Coverage Δ
hive	53.18% <66.66%> (+0.01%)	⬆️
mysql	79.21% <100.00%> (+<0.01%)	⬆️
postgres	79.29% <100.00%> (+<0.01%)	⬆️
presto	53.09% <66.66%> (+0.01%)	⬆️
python	83.14% <100.00%> (+<0.01%)	⬆️
sqlite	77.78% <100.00%> (+<0.01%)	⬆️
unit	53.03% <75.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/base.py	90.78% <100.00%> (-0.08%)	⬇️
superset/db_engine_specs/bigquery.py	70.22% <100.00%> (+0.55%)	⬆️
superset/db_engine_specs/presto.py	87.84% <100.00%> (-0.08%)	⬇️
superset/models/core.py	89.72% <100.00%> (-0.03%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM

[michael-s-molina]

Suggested change

	table_name,
	database,
	table_name=table_name,
	database=database,

[john-bodley]

I tend to only provide keywords if the variable names differ.

[michael-s-molina]

No problem. I generally like to always provide the pair to remove any ordering requirements. By the way, keyword arguments is one of my favorite Python features.