Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature flags): updating the status of a few flags #23670

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

While writing a blog post (coming soon!) I found a few feature flags with categorizations that seemed out of date. This should bring things up to date.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #23670 (d8222a7) into master (04bd528) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23670      +/-   ##
==========================================
- Coverage   68.08%   67.93%   -0.16%     
==========================================
  Files        1920     1920              
  Lines       73990    73990              
  Branches     8091     8091              
==========================================
- Hits        50374    50263     -111     
- Misses      21547    21658     +111     
  Partials     2069     2069              
Flag Coverage Δ
hive ?
javascript 54.09% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto ?
python 82.83% <ø> (-0.32%) ⬇️
sqlite 77.78% <ø> (ø)
unit 53.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousoph
Copy link
Member

yousoph commented Apr 17, 2023

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.91.175.109:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 4d97ece into master Apr 21, 2023
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@rusackas rusackas deleted the Flag-category-upgates branch May 11, 2023 16:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants