Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove RemovedInMarshmallow4 warnings #23704

Merged
merged 6 commits into from
Apr 21, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

Since marshmallow 3.10 passing field metadata via keyword arguments is deprecated. Since marshmallow 3.13 the use of missing / default is deprecated. This generates a lot of warnings during testing and prevents future upgrades to marshmallow >4.
This PR makes changes accordingly.

TESTING INSTRUCTIONS

pytest or ./scripts/tests/run.sh

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #23704 (4776847) into master (60c9d68) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4776847 differs from pull request most recent head 3c46c36. Consider uploading reports for the commit 3c46c36 to get more accurate results

@@           Coverage Diff           @@
##           master   #23704   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files        1922     1922           
  Lines       74103    74103           
  Branches     8101     8101           
=======================================
  Hits        50480    50480           
  Misses      21545    21545           
  Partials     2078     2078           
Flag Coverage Δ
hive 53.25% <100.00%> (ø)
mysql 79.24% <100.00%> (ø)
postgres 79.32% <100.00%> (ø)
presto 53.17% <100.00%> (ø)
python 83.17% <100.00%> (ø)
sqlite 77.81% <100.00%> (ø)
unit 53.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cachekeys/schemas.py 100.00% <ø> (ø)
superset/dashboards/permalink/schemas.py 100.00% <ø> (ø)
superset/db_engine_specs/bigquery.py 70.22% <ø> (ø)
superset/db_engine_specs/databricks.py 70.42% <ø> (ø)
superset/db_engine_specs/gsheets.py 76.47% <ø> (ø)
superset/explore/permalink/schemas.py 100.00% <ø> (ø)
superset/temporary_cache/schemas.py 100.00% <ø> (ø)
superset/views/datasource/schemas.py 97.22% <ø> (ø)
superset/advanced_data_type/schemas.py 100.00% <100.00%> (ø)
superset/annotation_layers/annotations/schemas.py 100.00% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all the hard work here, this will really help when we upgrade to Marshmallow 4 👍

@villebro villebro merged commit b31efba into apache:master Apr 21, 2023
@sebastianliebscher sebastianliebscher deleted the chore_marshmallow branch April 25, 2023 21:58
sebastianliebscher added a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
sadpandajoe added a commit to preset-io/superset that referenced this pull request May 5, 2023
sadpandajoe added a commit to preset-io/superset that referenced this pull request May 12, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants