Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Address spelling mistakes #23832

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

As titled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review April 26, 2023 18:53
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #23832 (7e769a1) into master (f3a6754) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 7e769a1 differs from pull request most recent head 91cf440. Consider uploading reports for the commit 91cf440 to get more accurate results

@@            Coverage Diff             @@
##           master   #23832      +/-   ##
==========================================
+ Coverage   67.99%   68.03%   +0.03%     
==========================================
  Files        1938     1938              
  Lines       74955    74955              
  Branches     8139     8139              
==========================================
+ Hits        50964    50993      +29     
+ Misses      21907    21878      -29     
  Partials     2084     2084              
Flag Coverage Δ
hive 53.01% <ø> (ø)
mysql 78.80% <ø> (ø)
postgres 78.87% <ø> (?)
presto 52.92% <ø> (ø)
python 82.67% <ø> (+0.07%) ⬆️
sqlite 77.39% <ø> (ø)
unit 52.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli/native_filters.py 0.00% <ø> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley force-pushed the john-bodley--fix-native-filters-spelling branch from 82b47c8 to 17be59a Compare April 26, 2023 20:05
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. We've gotta get @jsoref's tooling running on CI one of these days.

@john-bodley john-bodley force-pushed the john-bodley--fix-native-filters-spelling branch from 17be59a to 23ea4aa Compare April 27, 2023 18:41
@john-bodley john-bodley force-pushed the john-bodley--fix-native-filters-spelling branch from 23ea4aa to 91cf440 Compare April 27, 2023 22:25
@john-bodley john-bodley merged commit 053dca1 into master Apr 27, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Apr 27, 2023
@john-bodley john-bodley deleted the john-bodley--fix-native-filters-spelling branch April 27, 2023 23:53
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request May 10, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants