chore: Add Cypress tests for drill by #23849

kgabryje · 2023-04-27T15:57:24Z

SUMMARY

Tested flows:

opening the drill by modal -> further drilling -> undo drilling for each supported chart
open Table view in drill by modal
verify that Edit chart button URL is correct
breadcrumbs content
metadata bar is present

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2023-04-27T16:07:43Z

Codecov Report

Merging #23849 (9578c68) into master (053dca1) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 9578c68 differs from pull request most recent head 4fb0643. Consider uploading reports for the commit 4fb0643 to get more accurate results

@@           Coverage Diff           @@
##           master   #23849   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1938     1938           
  Lines       74958    74970   +12     
  Branches     8141     8141           
=======================================
+ Hits        51055    51065   +10     
- Misses      21824    21826    +2     
  Partials     2079     2079

Flag	Coverage Δ
hive	`53.01% <ø> (ø)`
mysql	`78.80% <ø> (ø)`
postgres	`78.87% <ø> (ø)`
presto	`52.92% <ø> (ø)`
python	`82.67% <ø> (ø)`
sqlite	`77.39% <ø> (ø)`
unit	`52.81% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tend/src/components/Chart/DrillBy/DrillByChart.tsx	`100.00% <ø> (ø)`
.../components/Chart/DrillBy/useDisplayModeToggle.tsx	`100.00% <ø> (ø)`
...c/components/Chart/DrillBy/useResultsTableView.tsx	`100.00% <ø> (ø)`
superset/examples/supported_charts_dashboard.py	`0.00% <ø> (ø)`
...tend/src/components/Chart/DrillBy/DrillByModal.tsx	`74.13% <75.00%> (+0.06%)`	⬆️
superset-frontend/src/logger/LogUtils.ts	`97.14% <100.00%> (+0.36%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

geido · 2023-04-28T11:41:16Z

tests/integration_tests/superset_test_config.py

@@ -61,7 +61,7 @@
 HIVE_POLL_INTERVAL = 0.1

 SQL_MAX_ROW = 10000
-SQLLAB_CTAS_NO_LIMIT = True  # SQL_MAX_ROW will not take affect for the CTA queries
+SQLLAB_CTAS_NO_LIMIT = True  # SQL_MAX_ROW will not take effect for the CTA queries


geido · 2023-04-28T11:46:17Z

superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts

+  cy.intercept('/api/v1/chart/data*').as(alias);
+};
+
+const interceptLegacyChartData = () => {


I think for this you can import the existing interceptExploreJson from explore/utils.ts

geido · 2023-04-28T11:47:42Z

superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts

+};
+
+const interceptFormDataKey = () => {
+  cy.intercept('/api/v1/explore/form_data').as('formDataKey');


For these other interceptors, it would be good to place them in the utils. For example, if this request happens only in the dashboard, we could put them in dashboard/utils for reusability

geido · 2023-04-28T11:49:35Z

superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts

+  });
+};
+
+const setTopLevelTab = (tabName: string) => {


I think we have this already in drilltodetail tests. Should it be moved to the utils?

geido · 2023-04-28T11:53:45Z

superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts

+      ]);
+    });
+
+    it.only('Mixed Chart', () => {


Ops only here

kgabryje · 2023-04-28T13:25:05Z

Thanks for comments @geido! All addressed

kgabryje requested a review from lilykuang April 27, 2023 15:57

kgabryje requested review from jinghua-qa, geido, eschutho, rusackas and betodealmeida as code owners April 27, 2023 15:57

pull-request-size bot added the size/XL label Apr 27, 2023

kgabryje added 8 commits April 28, 2023 08:51

chore: Add Cypress tests for drill by

c5eaf72

Add tests for supported charts

ab2d88f

Add test for Mixed Series

f0b1153

fix test

1c7df0a

fix test

3c7e4b1

shorter wait

623e88f

fix test

2a12bd8

fix test

5f6262a

kgabryje force-pushed the chore/drill-by-e2e branch from 71c1375 to 5f6262a Compare April 28, 2023 06:51

fix test

e5d64ce

geido reviewed Apr 28, 2023

View reviewed changes

Move util functions to utils

4fb0643

geido approved these changes Apr 28, 2023

View reviewed changes

kgabryje merged commit 60046ca into apache:master Apr 28, 2023

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add Cypress tests for drill by #23849

chore: Add Cypress tests for drill by #23849

kgabryje commented Apr 27, 2023

codecov bot commented Apr 27, 2023 •

edited

Loading

geido Apr 28, 2023

geido Apr 28, 2023

geido Apr 28, 2023 •

edited

Loading

geido Apr 28, 2023

geido Apr 28, 2023

kgabryje commented Apr 28, 2023

chore: Add Cypress tests for drill by #23849

chore: Add Cypress tests for drill by #23849

Conversation

kgabryje commented Apr 27, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Apr 27, 2023 • edited Loading

Codecov Report

geido Apr 28, 2023

Choose a reason for hiding this comment

geido Apr 28, 2023

Choose a reason for hiding this comment

geido Apr 28, 2023 • edited Loading

Choose a reason for hiding this comment

geido Apr 28, 2023

Choose a reason for hiding this comment

geido Apr 28, 2023

Choose a reason for hiding this comment

kgabryje commented Apr 28, 2023

codecov bot commented Apr 27, 2023 •

edited

Loading

geido Apr 28, 2023 •

edited

Loading