-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Native time range filter in legacy charts #23865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23865 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 1938 1938
Lines 74958 74975 +17
Branches 8141 8141
=======================================
+ Hits 51055 51069 +14
- Misses 21824 21827 +3
Partials 2079 2079
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up FEATURE_GENERIC_CHART_AXES=true |
@kgabryje Container image not yet published for this PR. Please try again when build is complete. |
@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details. |
I wonder if this would fix #23773 ? Seems like the same issue except I believe my affected charts are the new EChart bar chart, not legacy. |
(cherry picked from commit 78833bc)
@eschutho I closed the related issue above, it appears fixed in 2.1.1 🙌 |
SUMMARY
Some legacy charts (e.g. Heatmap and Bar Chart) were not getting dashboard time range filters applied with GENERIC_CHART_AXES enabled. This PR manually converts the time range into an adhoc filter, similarly how it's done for v1 charts.
Additionally, this PR brings back the time section for Calendar Heatmap chart, which was broken without it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION