Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout should be an integer #23924

Merged
merged 1 commit into from
May 3, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

The cache timeout should be an integer, but we're setting it to None when it's not specified. Instead, we should use 0 for no expiration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #23924 (79a0963) into master (db9a9cf) will increase coverage by 0.08%.
The diff coverage is 87.50%.

❗ Current head 79a0963 differs from pull request most recent head 01ef832. Consider uploading reports for the commit 01ef832 to get more accurate results

@@            Coverage Diff             @@
##           master   #23924      +/-   ##
==========================================
+ Coverage   68.02%   68.11%   +0.08%     
==========================================
  Files        1938     1940       +2     
  Lines       74997    75009      +12     
  Branches     8152     8152              
==========================================
+ Hits        51015    51090      +75     
+ Misses      21900    21836      -64     
- Partials     2082     2083       +1     
Flag Coverage Δ
hive 53.02% <64.28%> (+<0.01%) ⬆️
mysql 78.81% <100.00%> (+<0.01%) ⬆️
postgres 78.89% <100.00%> (?)
presto 52.93% <64.28%> (+<0.01%) ⬆️
python 82.68% <100.00%> (+0.17%) ⬆️
sqlite 77.40% <100.00%> (?)
unit 52.82% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 58.52% <ø> (+0.23%) ⬆️
...set-frontend/src/components/Select/AsyncSelect.tsx 88.46% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 90.41% <ø> (ø)
...nd/src/explore/components/RunQueryButton/index.tsx 100.00% <ø> (ø)
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/setup/setupFormatters.ts 0.00% <ø> (ø)
superset-frontend/src/types/bootstrapTypes.ts 100.00% <ø> (ø)
superset/cli/native_filters.py 0.00% <ø> (ø)
superset/dashboards/api.py 92.54% <ø> (+0.43%) ⬆️
superset/views/base.py 76.87% <ø> (ø)
... and 11 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit ad19cd9 into apache:master May 3, 2023
26 checks passed
@betodealmeida betodealmeida deleted the fix_cache_timeout branch May 3, 2023 20:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants