Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout should be an integer #23924

Merged
merged 1 commit into from
May 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions superset/utils/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ def view_cache_key(*args: Any, **kwargs: Any) -> str: # pylint: disable=unused-


def memoized_func(
key: Optional[str] = None,
cache: Cache = cache_manager.cache,
key: Optional[str] = None, cache: Cache = cache_manager.cache
) -> Callable[..., Any]:
"""
Decorator with configurable key and cache backend.
Expand Down Expand Up @@ -143,7 +142,7 @@ def wrapped_f(*args: Any, **kwargs: Any) -> Any:
if not kwargs.get("force") and obj is not None:
return obj
obj = f(*args, **kwargs)
cache.set(cache_key, obj, timeout=kwargs.get("cache_timeout"))
cache.set(cache_key, obj, timeout=kwargs.get("cache_timeout", 0))
return obj

return wrapped_f
Expand Down
Loading