Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark explore_json as deprecated in 3.0 #23976

Merged
merged 1 commit into from
May 10, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Mark the explore_json endpoint as being deprecated in 3.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #23976 (bf4dfb3) into master (d96b72d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head bf4dfb3 differs from pull request most recent head 88a5d35. Consider uploading reports for the commit 88a5d35 to get more accurate results

@@            Coverage Diff             @@
##           master   #23976      +/-   ##
==========================================
+ Coverage   68.18%   68.20%   +0.02%     
==========================================
  Files        1941     1941              
  Lines       75287    75289       +2     
  Branches     8177     8177              
==========================================
+ Hits        51332    51349      +17     
+ Misses      21860    21845      -15     
  Partials     2095     2095              
Flag Coverage Δ
hive 53.18% <100.00%> (+<0.01%) ⬆️
mysql 78.90% <100.00%> (?)
postgres 78.97% <100.00%> (+<0.01%) ⬆️
presto 53.10% <100.00%> (+<0.01%) ⬆️
python 82.75% <100.00%> (+0.04%) ⬆️
sqlite 77.50% <100.00%> (+<0.01%) ⬆️
unit 52.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.38% <100.00%> (+0.25%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -568,6 +568,7 @@ def annotation_json( # pylint: disable=no-self-use
@permission_name("explore_json")
@expose("/explore_json/data/<cache_key>", methods=("GET",))
@check_resource_permissions(check_explore_cache_perms)
@deprecated(eol_version="3.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could't find any documentation on "eol_version", only "version". Is "eol_version" when it was first deprecated or when it is planned to be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it's when it's getting removed (end-of-life)

@betodealmeida betodealmeida merged commit 2a2f8a8 into master May 10, 2023
@rusackas rusackas deleted the deprecate_explore_json branch May 11, 2023 16:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants