Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add version for postgres when doing brew install #24025

Merged
merged 2 commits into from
May 15, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 11, 2023

SUMMARY

Hopefully this change to the docs points users toward the right thing to do here! This should resolve an error that I (and apparently others) ran into. Fixes #22897

Added bycatch: fixing a link that was breaking builds. Apparently you can't use a relative link that goes outside the docusaurus folder, so I just used a link to the referenced file on the repo.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #24025 (d806846) into master (d96b72d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24025      +/-   ##
==========================================
+ Coverage   68.18%   68.22%   +0.03%     
==========================================
  Files        1941     1941              
  Lines       75287    75287              
  Branches     8177     8177              
==========================================
+ Hits        51332    51361      +29     
+ Misses      21860    21825      -35     
- Partials     2095     2101       +6     
Flag Coverage Δ
hive 53.17% <ø> (ø)
javascript 54.57% <ø> (+0.03%) ⬆️
mysql 78.90% <ø> (?)
postgres 78.97% <ø> (ø)
presto 53.09% <ø> (ø)
python 82.75% <ø> (+0.04%) ⬆️
sqlite 77.50% <ø> (ø)
unit 52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 2f33c47 into master May 15, 2023
@rusackas rusackas deleted the docs-postgres-version-for-brew-install branch May 15, 2023 16:30
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation error
3 participants