feat: Configurable default row limit for native filters

[cleslie]

SUMMARY

The default row limit for native filters was previously hardcoded to 1000. This PR makes this configurable through a new config property called NATIVE_FILTER_DEFAULT_ROW_LIMIT. This solves issue: #20521

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24043 (3fd8e12) into master (218d1c7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3fd8e12 differs from pull request most recent head d7988e2. Consider uploading reports for the commit d7988e2 to get more accurate results

@@            Coverage Diff             @@
##           master   #24043      +/-   ##
==========================================
- Coverage   68.30%   68.29%   -0.02%     
==========================================
  Files        1957     1957              
  Lines       75590    75595       +5     
  Branches     8223     8224       +1     
==========================================
- Hits        51635    51625      -10     
- Misses      21848    21863      +15     
  Partials     2107     2107              

Flag	Coverage Δ
hive	53.36% <100.00%> (+<0.01%)	⬆️
javascript	54.73% <100.00%> (+<0.01%)	⬆️
mysql	?
postgres	78.99% <100.00%> (+<0.01%)	⬆️
presto	53.29% <100.00%> (+<0.01%)	⬆️
python	82.77% <100.00%> (-0.05%)	⬇️
sqlite	77.53% <100.00%> (+<0.01%)	⬆️
unit	53.42% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/base.py	77.21% <ø> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts	50.00% <100.00%> (+3.33%)	⬆️
superset/config.py	92.02% <100.00%> (+0.02%)	⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rusackas]

My only head-scratcher on this is whether or not there's a way to fetch the setting by other means (i.e. an API call) since I think we're trying to reduce reliance on the server-generated bootstrap data blob. I tagged a few people who know more about this game than I do :)

[cleslie]

My only head-scratcher on this is whether or not there's a way to fetch the setting by other means (i.e. an API call) since I think we're trying to reduce reliance on the server-generated bootstrap data blob. I tagged a few people who know more about this game than I do :)

Hey thanks, happy to change it however you or others prefer.

[michael-s-molina]

My only head-scratcher on this is whether or not there's a way to fetch the setting by other means (i.e. an API call) since I think we're trying to reduce reliance on the server-generated bootstrap data blob. I tagged a few people who know more about this game than I do :)

For me, the problem is not about having some form of bootstrap data, because we do have initial global configurations, but the way we're currently doing. I'm ok with the approach for now, as we didn't define a new model to get these global configurations yet (or did we?).

[cleslie]

Hi, thanks for the comments, if you are happy with this approach is there anything preventing this from being merged?