Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Updating DB connection instructions in 1st Dash instruct… #24081

Merged
merged 3 commits into from
May 17, 2023

Conversation

rusackas
Copy link
Member

…ions

SUMMARY

The docs for connecting to a DB in the "Creating Your First Dashboard" section were out of date. This PR updates the instructions a bit, and adds updated screenshots.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #24081 (8c44076) into master (58e1bcd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24081   +/-   ##
=======================================
  Coverage   68.25%   68.25%           
=======================================
  Files        1942     1942           
  Lines       75192    75192           
  Branches     8145     8145           
=======================================
  Hits        51322    51322           
  Misses      21785    21785           
  Partials     2085     2085           
Flag Coverage Δ
hive 53.19% <ø> (ø)
mysql 78.96% <ø> (ø)
postgres 79.03% <ø> (ø)
presto 53.12% <ø> (ø)
python 82.83% <ø> (ø)
sqlite 77.55% <ø> (ø)
unit 53.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member Author

@sfirke @kikobarr @eschutho here's the PR from today's lil' session, for your consideration.

@rusackas rusackas requested review from eschutho and hughhhh May 16, 2023 18:30
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rusackas rusackas merged commit 614b0aa into master May 17, 2023
@rusackas rusackas deleted the Updated-connection-instructions branch May 17, 2023 15:58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants