fix: Copy dashboard filters when copying dashboard #24303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24303 +/- ##
==========================================
+ Coverage 66.53% 68.31% +1.78%
==========================================
Files 1957 1957
Lines 75623 75624 +1
Branches 8224 8224
==========================================
+ Hits 50312 51663 +1351
+ Misses 23202 21852 -1350
Partials 2109 2109
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 95 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfrag1
commented
Jun 6, 2023
| @@ -154,6 +154,34 @@ def test_copy_dashboard(self, mock_g): | |||
| db.session.delete(dash) | |||
| db.session.commit() | |||
|
|
|||
| @pytest.mark.usefixtures("load_world_bank_dashboard_with_slices") | |||
| @patch("superset.dashboards.dao.g") | |||
| def test_copy_dashboard_copies_native_filters(self, mock_g): | |||
There was a problem hiding this comment.
test fails without this fix
eschutho
approved these changes
Jun 6, 2023
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit e791ba5)
|
🏷️ preset:2023.23 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR will make it so that dashboard native filters are properly copied when copying a dashboard using the "Save as" option in the UI. This functionality broke as a result of an api v1 migration.
set_dash_metadatajust takes the current dash's params and adds certain keys from the data dict passed in. Before callingset_dash_metadata, the newly copied dashboard should share the same metadata as the original dash so that no keys are lost, in this casenative_filter_configurationwas being lost.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION