chore: Deprecates some NVD3 charts in 3.0 #24322
Conversation
michael-s-molina
requested review from
jinghua-qa,
geido,
eschutho and
betodealmeida
as code owners
Codecov Report
@@ Coverage Diff @@
## master #24322 +/- ##
==========================================
+ Coverage 68.33% 68.60% +0.27%
==========================================
Files 1957 1941 -16
Lines 75628 75201 -427
Branches 8225 8215 -10
==========================================
- Hits 51680 51595 -85
+ Misses 21835 21494 -341
+ Partials 2113 2112 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -24,11 +24,15 @@ import controlPanel from './controlPanel'; | |||
| const metadata = new ChartMetadata({ | |||
| credits: ['http://nvd3.org'], | |||
| description: '', | |||
| name: t('Pie Chart'), | |||
| name: t('Pie Chart (deprecated)'), | |||
There was a problem hiding this comment.
Hmm, I wonder if it's fair to add deprecated: true to the metadata here, which would hide it from the viz gallery. Maybe we should gather some thoughts on this at Town Hall tomorrow? I'll stick it on the agenda.
There was a problem hiding this comment.
This one does not appear in the viz gallery already. I just marked it as deprecated to be removed in 4.0.
There was a problem hiding this comment.
LGTM, with possible add-ons (which could be a separate PR, they're certainly non-blocking):
- Maybe we should also remove them from the viz gallery (existing charts left in place)
OR - Maybe we should add
label: ChartLabel.DEPRECATEDto their metadata, which adds the visible "DEPRECATED" label in the viz gallery.
I didn't know about this label. I'll add the label to all 👍🏼 |
|
@rusackas I added the DEPRECATED label to all and kept the (legacy) suffix in the name. I updated the PR image to reflect the change. |
mistercrunch
added
🏷️ bot
SUMMARY
Deprecates the following NVD3 charts in 3.0 to be removed in the next major version:
NVD3 charts that have a migration and an ECharts replacement will be removed in 3.0. The others remain untouched until we provide a migration and ECharts replacement in a future major version.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
ADDITIONAL INFORMATION