Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating images and markdown #24462

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

rusackas
Copy link
Member

SUMMARY

Updating some outdated images (though not all of them 😅) and corresponding markdown

Hat tip to @kikobarr

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

Ran the Docusarus site locally - you can too!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #24462 (3c99814) into master (fdef9cb) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24462      +/-   ##
==========================================
+ Coverage   68.94%   69.02%   +0.07%     
==========================================
  Files        1901     1901              
  Lines       73974    73974              
  Branches     8119     8119              
==========================================
+ Hits        50999    51057      +58     
+ Misses      20864    20806      -58     
  Partials     2111     2111              
Flag Coverage Δ
hive 54.17% <ø> (+0.27%) ⬆️
javascript 55.65% <ø> (ø)
mysql 79.40% <ø> (ø)
postgres 79.49% <ø> (?)
presto ?
python 83.47% <ø> (+0.16%) ⬆️
sqlite 77.99% <ø> (?)
unit 54.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley changed the title updating images and markdown docs: updating images and markdown Jun 21, 2023
@rusackas rusackas assigned hughhhh and unassigned hughhhh Jun 22, 2023
@rusackas rusackas self-assigned this Jun 22, 2023
@rusackas rusackas merged commit bf93381 into master Jun 29, 2023
54 of 55 checks passed
@rusackas rusackas deleted the updating-chart-resizing-images branch June 29, 2023 19:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants