fix: Total calculation in stacked Timeseries charts

[michael-s-molina]

SUMMARY

This PR fixes the following bugs:

• The totals where not correctly calculated in stacked Timeseries charts when interacting with the legend
• Double clicking a series was not exclusively selecting it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-06-21.at.19.07.26.mov

Screen.Recording.2023-06-21.at.18.56.50.mov

TESTING INSTRUCTIONS

1 - Make sure the totals are correctly calculated for Timeseries charts when interacting with the legend.
2 - Make sure that double clicking on a series exclusively selects it

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Thanks for the fix + cleanup. One concern about bloating ChartProps, but other than that LGTM. Let's try to find some time to hack on Plugin Arch v2 sometime!

[villebro]

I want to raise the concern of bloating the number of different states we have here: Would it make sense to introduce something more generic, like chartState that could be leveraged for transporting other info, too? I assume this isn't the last time we need to ship back info from the plugin to transformProps, and having to add a new property can become tedious at some point. Thoughts? Alternatively, let's not do this now, but do a full cleanup when we get around to building the new React-based plugin arch (v2).

[michael-s-molina]

I totally agree with your concern. I have many other concerns regarding the current plugin architecture but I think the best approach would be to stop amending the flawed design and think about a cleaner v2. One thing I think is really hard with the current structure is to properly test the plugin behaviors.