Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: screenshot reports with custom width #24549

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Follow up to #24547, use the stored custom_width and custom_heigth when generating report screenshots.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #24549 (4d76032) into master (be9eb0f) will increase coverage by 13.81%.
The diff coverage is 100.00%.

❗ Current head 4d76032 differs from pull request most recent head 0420093. Consider uploading reports for the commit 0420093 to get more accurate results

@@             Coverage Diff             @@
##           master   #24549       +/-   ##
===========================================
+ Coverage   55.26%   69.08%   +13.81%     
===========================================
  Files        1906     1906               
  Lines       74157    74141       -16     
  Branches     8161     8154        -7     
===========================================
+ Hits        40985    51222    +10237     
+ Misses      31053    20800    -10253     
  Partials     2119     2119               
Flag Coverage Δ
hive 53.93% <0.00%> (?)
mysql 79.39% <100.00%> (?)
postgres 79.48% <100.00%> (?)
presto 53.83% <0.00%> (?)
python 83.48% <100.00%> (+28.78%) ⬆️
sqlite 78.04% <100.00%> (?)
unit 54.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/execute.py 92.02% <100.00%> (+92.02%) ⬆️

... and 331 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida changed the base branch from customize_screenshot_width to master June 29, 2023 21:34
@betodealmeida betodealmeida requested a review from a team as a code owner June 29, 2023 21:34
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jun 29, 2023
@betodealmeida betodealmeida force-pushed the generate_screenshots_custom_width branch from dbbbdbc to 74cecb1 Compare June 29, 2023 21:36
@pull-request-size pull-request-size bot added size/S and removed size/L labels Jun 29, 2023
@betodealmeida betodealmeida force-pushed the generate_screenshots_custom_width branch from 74cecb1 to 0420093 Compare June 29, 2023 21:55
@betodealmeida betodealmeida merged commit a740c2c into master Jun 30, 2023
55 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the generate_screenshots_custom_width branch March 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants