fix: Validation of out of scope filters and interaction with Clear All

[michael-s-molina]

SUMMARY

Changes the validation of required filters to only be applicable to filters in scope. It also changes the Clear All feature to only affect filters in scope.

Fixes #24496

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-07-06.at.16.46.45.mov

TESTING INSTRUCTIONS

Check the video and original issue for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

When you click clear all, the query is run for the chart even though the filter is required. I don't think it's expected behaviour since we can't run the query with Apply button.

[michael-s-molina]

When you click clear all, the query is run for the chart even though the filter is required. I don't think it's expected behaviour since we can't run the query with Apply button.

@kgabryje this bug already exists on master but I added a fix here anyway. Clear all won't fire ANY query if there's an in scope required filter that needs to be filled. Keep in mind that no chart will be updated until this state is first resolved, independently if a chart is affected by the in scope required filter.

Screen.Recording.2023-07-10.at.12.17.08.mov

@yousoph @kgabryje @rusackas A possible alternative would be to exclude required filters from the Clear All action and only clear non-required filters. Let me know what you think about it.

[kgabryje]

I think it's an optimal solution. The other approach might be to reset the required filter to the default value, but I think it's less intuitive than just clearing the control

[kgabryje]

LGTM