Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): edit without custom width #24612

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Allow passing an empty custom_width when configuring a report.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #24612 (8d14e2f) into master (6657353) will increase coverage by 0.00%.
The diff coverage is 57.14%.

❗ Current head 8d14e2f differs from pull request most recent head 33823c2. Consider uploading reports for the commit 33823c2 to get more accurate results

@@           Coverage Diff           @@
##           master   #24612   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files        1906     1906           
  Lines       74114    74118    +4     
  Branches     8165     8165           
=======================================
+ Hits        51213    51217    +4     
  Misses      20778    20778           
  Partials     2123     2123           
Flag Coverage Δ
hive 54.14% <42.85%> (-0.01%) ⬇️
mysql 79.47% <42.85%> (-0.01%) ⬇️
postgres 79.55% <42.85%> (-0.02%) ⬇️
presto 54.04% <42.85%> (-0.01%) ⬇️
python 83.53% <57.14%> (+<0.01%) ⬆️
sqlite 78.12% <42.85%> (-0.01%) ⬇️
unit 54.83% <57.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/schemas.py 92.38% <57.14%> (+1.29%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit 93ba4ad into master Jul 7, 2023
54 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 7, 2023
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 7, 2023
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.27

michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the fix-custom-width branch March 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants