-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Re-enable some GitHub action workflows in draft mode #24626
chore: Re-enable some GitHub action workflows in draft mode #24626
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24626 +/- ##
==========================================
+ Coverage 68.97% 69.08% +0.10%
==========================================
Files 1907 1907
Lines 74153 74153
Branches 8182 8182
==========================================
+ Hits 51148 51225 +77
+ Misses 20882 20805 -77
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
45731b3
to
80a1a50
Compare
@michael-s-molina per our conversation earlier today I relaxed the constraint to remove the draft checks from all the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @john-bodley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
SUMMARY
This is a partial revert of #12666 which was likely authored when Apache's CI was under heavy load. Specifically it reenables all the workflows when a PR is in draft mode. This enables the author to iterate on fixing any issues prior to it being deemed eligible for review.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and additionally ensured there were no references to
draft
in the GitHub actions, i.e.,ADDITIONAL INFORMATION