Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-enable some GitHub action workflows in draft mode #24626

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 7, 2023

SUMMARY

This is a partial revert of #12666 which was likely authored when Apache's CI was under heavy load. Specifically it reenables all the workflows when a PR is in draft mode. This enables the author to iterate on fixing any issues prior to it being deemed eligible for review.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI and additionally ensured there were no references to draft in the GitHub actions, i.e.,

$ git grep draft .github
$

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #24626 (e47032d) into master (c53b249) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head e47032d differs from pull request most recent head 45731b3. Consider uploading reports for the commit 45731b3 to get more accurate results

@@            Coverage Diff             @@
##           master   #24626      +/-   ##
==========================================
+ Coverage   68.97%   69.08%   +0.10%     
==========================================
  Files        1907     1907              
  Lines       74153    74153              
  Branches     8182     8182              
==========================================
+ Hits        51148    51225      +77     
+ Misses      20882    20805      -77     
  Partials     2123     2123              
Flag Coverage Δ
hive 54.14% <ø> (?)
javascript 55.75% <ø> (ø)
mysql 79.47% <ø> (?)
postgres 79.56% <ø> (ø)
presto 54.04% <ø> (ø)
python 83.54% <ø> (+0.21%) ⬆️
sqlite 78.12% <ø> (ø)
unit 54.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley removed the request for review from eschutho July 8, 2023 16:59
@john-bodley john-bodley force-pushed the john-bodley--partial-revert-12666 branch from 45731b3 to 80a1a50 Compare July 11, 2023 02:10
@john-bodley
Copy link
Member Author

@michael-s-molina per our conversation earlier today I relaxed the constraint to remove the draft checks from all the workflows.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @john-bodley

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rusackas rusackas merged commit cbf3965 into apache:master Jul 11, 2023
28 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants