chore: Update Rockset—switching out rockset for rockset-sqlalchemy #24649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gadhagod
changed the title
john-bodley
reviewed
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #24649 +/- ##
==========================================
- Coverage 69.08% 69.05% -0.03%
==========================================
Files 1906 1908 +2
Lines 74114 74173 +59
Branches 8155 8178 +23
==========================================
+ Hits 51200 51219 +19
- Misses 20795 20833 +38
- Partials 2119 2121 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
changed the title
john-bodley
changed the title
john-bodley
reviewed
Jul 11, 2023
| | [SAP Hana](/docs/databases/hana) | `pip install hdbcli sqlalchemy-hana or pip install apache-superset[hana]` | `hana://{username}:{password}@{host}:{port}` | | ||
| | [StarRocks](/docs/databases/starrocks) | `pip install starrocks` | `starrocks://<User>:<Password>@<Host>:<Port>/<Catalog>.<Database>` | | ||
| | [Snowflake](/docs/databases/snowflake) | `pip install snowflake-sqlalchemy` | `snowflake://{user}:{password}@{account}.{region}/{database}?role={role}&warehouse={warehouse}` | | ||
| | SQLite | No additional library needed | `sqlite://` | | ||
| | [SQL Server](/docs/databases/sql-server) | `pip install pymssql` | `mssql+pymssql://` | | ||
| | [Teradata](/docs/databases/teradata) | `pip install teradatasqlalchemy` | `teradatasql://{user}:{password}@{host}` | | ||
| | [TimescaleDB](/docs/databases/timescaledb) | `pip install psycopg2` | `postgresql://<UserName>:<DBPassword>@<Database Host>:<Port>/<Database Name>` | | ||
| | [Trino](/docs/databases/trino) | `pip install trino` | `trino://{username}:{password}@{hostname}:{port}/{catalog}` | |
There was a problem hiding this comment.
Thanks for making this ABC.
john-bodley
approved these changes
Jul 11, 2023
9 tasks
|
@john-bodley or @betodealmeida is this going to be a breaking change? For people who use rockset, they'll need to change the driver that they use. Even though the driver itself is backward compatible, the import of the old driver will no longer work given the new requirements in Superset. |
eschutho
added
the
risk:breaking-change
|
@eschutho I'm not sure. The SQLAlchemy URI is unchanged as far as I'm can tell and thus it's no more breaking than other changes which bump an eligible version of a package. |
mistercrunch
added
🏷️ bot
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: bump rockset
docs: update Rockset usage (include virtual instance configuration)
SUMMARY
superset used a very old version of
rockset(0.8.10). The latest version is 2.0.0. However, SQLAlchemy support no longer comes withrocksetand has been separated into its own package,rockset-sqlalchemy. I have updatedsetup.pyto reference this new package. This change should be completely backward compatible.This new package comes with the ability to target specific virtual instances through the SQLAlchemy connection URI. I have updated the docs to show this new feature.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION