chore: consolidate sqllab store into SPA store #25088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for the PR @justinpark! I left some first-pass comments.
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
Outdated
Show resolved
Hide resolved
justinpark
force-pushed
the
chore--consolidate-sqllab-store
branch
from
588c944
to
f425af8
Compare
|
Hey @michael-s-molina! Can you review it again? |
michael-s-molina
approved these changes
Aug 30, 2023
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part 3 of SQLLab SPA migration: detail link
This commit consolidates the SqlLab store into SPA store. In order to support the legacy SqlLab page, this commit organizes the existing SqlLab enhancers (for persistence mode) into the shared module and uses in both SqlLab and SPA store. This commit also fixes
RESET_STATEaction which will be used in the SqlLab entry page with the useSqlLabInitialState in the next PR.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After: (queryApi and sqlLab has been added on all SPA views)
TESTING INSTRUCTIONS
Test SQL lab and SPA pages without errors
ADDITIONAL INFORMATION