Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more migration tests #25262

Merged
merged 1 commit into from
Nov 8, 2023
Merged

chore: add more migration tests #25262

merged 1 commit into from
Nov 8, 2023

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 12, 2023 •
edited
Loading

SUMMARY

Adds more tests for some util functions for migrations. No functional changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho requested a review from a team as a code owner September 12, 2023 01:07
@michael-s-molina
Copy link
Member

@eschutho Tip: Now you can create Draft PRs and all CI checks will run 😉

@eschutho eschutho force-pushed the elizabeth/fix-migration-constraint-check branch from 1d2dbf2 to c589bf7 Compare October 25, 2023 23:19
@eschutho eschutho marked this pull request as draft October 27, 2023 00:27
@eschutho eschutho force-pushed the elizabeth/fix-migration-constraint-check branch from c0ed300 to 9c5d5e9 Compare October 28, 2023 00:36
@eschutho eschutho changed the title [DRAFT] fix: add checks for when constraint already exists chore: add migration tests Oct 28, 2023
@eschutho eschutho changed the title chore: add migration tests chore: add more migration tests Oct 28, 2023
@eschutho eschutho marked this pull request as ready for review November 4, 2023 00:08
Antonio-RiveroMartnez
Antonio-RiveroMartnez approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eschutho eschutho merged commit 1d0b86a into apache:master Nov 8, 2023
51 of 52 checks passed
@eschutho eschutho deleted the elizabeth/fix-migration-constraint-check branch November 8, 2023 01:06
@michael-s-molina
Copy link
Member

giphy

josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@eschutho @josedev-union
chore: add more migration tests (apache#25262)
4ca4a70
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@eschutho
chore: add more migration tests (apache#25262)
acb1bfb
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@eschutho @sfirke
chore: add more migration tests (apache#25262)
ffeac56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eschutho @michael-s-molina @Antonio-RiveroMartnez @mistercrunch