chore(async): Making create app configurable #25346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
commented
Sep 19, 2023
| @@ -0,0 +1,127 @@ | |||
| # | |||
There was a problem hiding this comment.
Added this config for local testing
craig-rueda
commented
Sep 19, 2023
| @@ -25,12 +26,14 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def create_app() -> Flask: | |||
| def create_app(superset_config_module: Optional[str] = None) -> Flask: | |||
There was a problem hiding this comment.
Adding optional override module for test configs
craig-rueda
commented
Sep 19, 2023
| ) | ||
|
|
||
| self._ssh_manager = ssh_manager_class(app) | ||
| self._ssh_manager = load_class_from_name( |
craig-rueda
commented
Sep 19, 2023
| ) | ||
|
|
||
| self._auth_provider = auth_provider_class(app.config["WEBDRIVER_AUTH_FUNC"]) | ||
| self._auth_provider = load_class_from_name( |
dpgaspar
reviewed
Sep 20, 2023
dpgaspar
approved these changes
Sep 20, 2023
hughhhh
approved these changes
Sep 20, 2023
eschutho
pushed a commit
to Superset-Community-Partners/superset
that referenced
this pull request
Sep 21, 2023
9 tasks
9 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
First of several PRs to revive Global Async Queries.
create_app()in order to facilitate integration test configs