Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update location of async_query_manager.py #25531

Merged
merged 2 commits into from
Nov 2, 2023
Merged

docs: Update location of async_query_manager.py #25531

merged 2 commits into from
Nov 2, 2023

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Oct 5, 2023 •
edited by john-bodley
Loading

SUMMARY

This PR updates the documentation for the location of the async_query_manager.py which was moved in PR #25346.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley changed the title fix: update location of async_query_manager.py docs: Update location of async_query_manager.py Oct 5, 2023
@sfirke
Copy link
Member

sfirke commented Nov 2, 2023

Thanks for fixing this!

@sfirke sfirke merged commit 508721b into apache:master Nov 2, 2023
31 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@emmanuel-ferdman @john-bodley
docs: Update location of async_query_manager.py (apache#25531)
b2a4d57 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@emmanuel-ferdman @john-bodley @sfirke
docs: Update location of async_query_manager.py (apache#25531)
1b91c37 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sfirke sfirke sfirke approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emmanuel-ferdman @sfirke @john-bodley @mistercrunch