Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-db): removed attribute #25525

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix(test-db): removed attribute #25525

merged 3 commits into from
Oct 5, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

The secondary_time_columns attribute was removed from DB engine specs in #25204. This PR updates the test-db command to work after that change. Also fix lint and a test that was broken.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

superset test-db sqlite:///test.db

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 5, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 5, 2023
@betodealmeida betodealmeida merged commit 89b0599 into master Oct 5, 2023
54 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@betodealmeida
fix(test-db): removed attribute (apache#25525)
2f29cd1
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the small_fixes_test_db branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betodealmeida @Antonio-RiveroMartnez @mistercrunch