Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pip-tools #25645

Merged
merged 1 commit into from
Oct 15, 2023
Merged

chore: bump pip-tools #25645

merged 1 commit into from
Oct 15, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented Oct 14, 2023

SUMMARY

Currently running pip-compile-multi fails on my devenv:

$ pip-compile-multi -P prophet
Locking requirements/base.in to requirements/base.txt. References: []
Locking requirements/integration.in to requirements/integration.txt. References: []
Locking requirements/development.in to requirements/development.txt. References: ['requirements/base.in']
Locking requirements/docker.in to requirements/docker.txt. References: ['requirements/base.in']
Locking requirements/local.in to requirements/local.txt. References: ['requirements/base.in', 'requirements/development.in']
Locking requirements/testing.in to requirements/testing.txt. References: ['requirements/base.in', 'requirements/development.in', 'requirements/integration.in']
ERROR executing /Users/ville/apple/apache-superset/venv/bin/python -m piptools compile --no-header --verbose --no-emit-index-url --resolver=legacy --emit-trusted-host --upgrade-package=prophet --rebuild --output-file requirements/testing.txt requirements/testing.in
Exit code: 1
/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")
Traceback (most recent call last):
  File "/Users/ville/.pyenv/versions/3.10-dev/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/ville/.pyenv/versions/3.10-dev/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/piptools/__main__.py", line 5, in <module>
    from piptools.scripts import compile, sync
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/piptools/scripts/sync.py", line 16, in <module>
    from .. import sync
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/piptools/sync.py", line 11, in <module>
    from pip._internal.commands.freeze import DEV_PKGS
ImportError: cannot import name 'DEV_PKGS' from 'pip._internal.commands.freeze' (/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pip/_internal/commands/freeze.py)

Traceback (most recent call last):
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pipcompilemulti/cli_v1.py", line 26, in cli
    recompile()
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pipcompilemulti/actions.py", line 31, in recompile
    compile_topologically(env_confs, deduplicator)
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pipcompilemulti/actions.py", line 38, in compile_topologically
    if env.maybe_create_lockfile():
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 51, in maybe_create_lockfile
    self.create_lockfile()
  File "/Users/ville/apple/apache-superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 80, in create_lockfile
    raise RuntimeError("Failed to pip-compile {0}".format(self.infile))
RuntimeError: Failed to pip-compile requirements/testing.in

After upgrading to 7.3.0 the problem appears to go away:

$ pip-compile-multi -P prophet
Locking requirements/base.in to requirements/base.txt. References: []
Locking requirements/integration.in to requirements/integration.txt. References: []
Locking requirements/development.in to requirements/development.txt. References: ['requirements/base.in']
Locking requirements/docker.in to requirements/docker.txt. References: ['requirements/base.in']
Locking requirements/local.in to requirements/local.txt. References: ['requirements/base.in', 'requirements/development.in']
Locking requirements/testing.in to requirements/testing.txt. References: ['requirements/base.in', 'requirements/development.in', 'requirements/integration.in']

Judging by the changes to the lock files people have been manually updating the lock files for a while now, so this may help unblock others trying to automatically update them with pip-compile-multi..

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Comment on lines -107 to -111
requests==2.31.0
# via
# pydruid
# tableschema
# tabulator
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since requests is already pulled in by shillelagh in base.txt, it's no longer explicitly needed in the development requirements.

Comment on lines -15 to -16
apsw==3.42.0.1
# via shillelagh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency is already in base.txt (also pulled in by shillelagh)

@villebro villebro merged commit 8c6bd4e into apache:master Oct 15, 2023
31 checks passed
@villebro villebro mentioned this pull request Oct 16, 2023
9 tasks
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants