Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(issues): config.yaml added with feature request link to open a discussion #25823

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 1, 2023

SUMMARY

Adds a link to the Issues template to open a GH discussion for feature requests

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #25823 (7ff2f9f) into master (3f28eeb) will decrease coverage by 2.07%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25823      +/-   ##
==========================================
- Coverage   69.02%   66.95%   -2.07%     
==========================================
  Files        1938     1938              
  Lines       75611    75611              
  Branches     8417     8417              
==========================================
- Hits        52187    50629    -1558     
- Misses      21263    22821    +1558     
  Partials     2161     2161              
Flag Coverage Δ
hive ?
mysql 78.37% <ø> (ø)
postgres 78.47% <ø> (ø)
presto ?
python 78.61% <ø> (-4.30%) ⬇️
sqlite 77.12% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 108 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit a249e41 into master Nov 1, 2023
51 checks passed
@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Nov 1, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…discussion (apache#25823)

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
…discussion (apache#25823)

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@mistercrunch mistercrunch deleted the CTA-for-feature-requests branch March 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants