Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagging): change key from name to id for tagToSelectOption #25856

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Nov 3, 2023

SUMMARY

I've adjusted the tagToSelectOption function to key off the id instead of the name. This is to address a specific issue with our async select component.
The component wasn't effectively using the data when name, value, and label were identical. This redundancy wasn't practical and didn't utilize the potential of unique identifiers.
By keying on id, which is inherently unique, the async select component now operates as intended, with clear and distinct options.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

@lilykuang would you mind flushing out the PR description (including testing instructions) and mention why using name rather than id was an issue—as this helps to provide context to the community. Additionally any unit tests would be greatly appreciated.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Nov 3, 2023
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Nov 3, 2023
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 3, 2023
@lilykuang lilykuang merged commit 30cd422 into apache:master Nov 6, 2023
26 checks passed
@lilykuang lilykuang deleted the fix-tagging branch November 6, 2023 17:44
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 6, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants