feat(telemetry): Adding Scarf based telemetry to Superset #26011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26011 +/- ##
==========================================
+ Coverage 69.10% 69.41% +0.31%
==========================================
Files 1940 1946 +6
Lines 75869 78721 +2852
Branches 8445 8935 +490
==========================================
+ Hits 52427 54642 +2215
- Misses 21267 21772 +505
- Partials 2175 2307 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rusackas
force-pushed
the
scarf-pixel
branch
from
fd0dfbe
to
a8e3bf9
Compare
rusackas
requested review from
michael-s-molina,
villebro,
kgabryje,
justinpark and
eschutho
|
The John ❤️ JS commit cracked me up! 🤣 |
villebro
approved these changes
Dec 2, 2023
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/TelemetryPixel/TelemetryPixel.test.tsx
Outdated
Show resolved
Hide resolved
9 tasks
… comes through as a string or a boolean.
michael-s-molina
added
the
v3.1
Comment on lines
+48
to
+49
| return process.env.SCARF_ANALYTICS === 'false' || | ||
| process.env.SCARF_ANALYTICS === 'false' ? null : ( |
There was a problem hiding this comment.
process.env.SCARF_ANALYTICS === 'false' ||
process.env.SCARF_ANALYTICS === 'false'
Just noticed this is duplicated.
There was a problem hiding this comment.
Yeesh... I thought I nabbed that. Will open a PR to clean up... Especially if this does not have the intended effect now. Surprised some linting rule doesn't spot this kind of thing.
michael-s-molina
removed
the
v3.1
9 tasks
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Dec 22, 2023
…ache#26011)" This reverts commit 8437a23.
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Jan 3, 2024
…ache#26011)" This reverts commit 8437a23.
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Jan 13, 2024
…ache#26011)" This reverts commit 8437a23.
9 tasks
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR does a handful of things:
TelemetryPixelcomponentENABLE_TELEMETRYfeature flagno-referrer-when-downgradeTypeError: Cannot redefine property: windowerrorTODO:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
RTL tests for the new component with FF on and off should pass. Run it, and have any PMC member check the Scarf data for proper capture.
ADDITIONAL INFORMATION