Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cleanup): removing redundant rendering logic in telemetry pixel #26293

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore(cleanup): removing redundant rendering logic in telemetry pixel #26293

merged 1 commit into from
Dec 18, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

This duplicated logic/syntax slipped through on #26011 — I'm surprised eslint didn't find this redundancy, but whatever... it's gone now :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit eb4b412 into master Dec 18, 2023
52 checks passed
sadpandajoe added a commit to preset-io/superset that referenced this pull request Dec 22, 2023
@sadpandajoe
Revert "chore(cleanup): removing redundant rendering logic in telemet…
9bf5ef1 
…ry pixel (apache#26293)"

This reverts commit eb4b412.
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jan 3, 2024
@sadpandajoe
Revert "chore(cleanup): removing redundant rendering logic in telemet…
aaa041f 
…ry pixel (apache#26293)"

This reverts commit eb4b412.
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jan 13, 2024
@sadpandajoe
Revert "chore(cleanup): removing redundant rendering logic in telemet…
026bfa3 
…ry pixel (apache#26293)"

This reverts commit eb4b412.
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @sfirke
chore(cleanup): removing redundant rendering logic in telemetry pixel (…
d26c94c 
…apache#26293)
@mistercrunch mistercrunch deleted the cleanup-telemetry-component branch March 26, 2024 18:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rusackas @michael-s-molina @mistercrunch