Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up the examples dashboards #26158

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 1, 2023

SUMMARY

This PR cleans up the examples dashboards by adjusting the dashboards layouts and removing:

  • All filter boxes
  • 2 charts with incorrect metadata
  • Charts that were previously removed

Fixes #26133

TESTING INSTRUCTIONS

1 - Make sure the command to load the examples runs successfully
2 - Make sure there's no filter box
3 - Make sure all charts render correctly
4 - Make sure there are no deleted charts

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9aaf0f) 58.93% compared to head (faea62e) 69.16%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #26158       +/-   ##
===========================================
+ Coverage   58.93%   69.16%   +10.23%     
===========================================
  Files        1941     1941               
  Lines       75873    75907       +34     
  Branches     8447     8457       +10     
===========================================
+ Hits        44714    52504     +7790     
+ Misses      28984    21207     -7777     
- Partials     2175     2196       +21     
Flag Coverage Δ
hive 53.68% <ø> (-0.01%) ⬇️
javascript 56.49% <ø> (+0.20%) ⬆️
mysql 78.08% <ø> (?)
postgres 78.17% <ø> (?)
presto 53.63% <ø> (-0.01%) ⬇️
python 82.86% <ø> (+21.07%) ⬆️
sqlite 76.83% <ø> (?)
unit 55.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Dec 1, 2023
@john-bodley
Copy link
Member

@michael-s-molina thanks for the cleanup. I suspect we're removing filter box from dashboards and thus ideally we replace said filter boxes with native filters.

@michael-s-molina
Copy link
Member Author

@michael-s-molina thanks for the cleanup. I suspect we're removing filter box from dashboards and thus ideally we replace said filter boxes with native filters.

We can do that as a follow-up. At the moment, the focus is on removing the inconsistencies and errors.

@michael-s-molina
Copy link
Member Author

/testenv up

Copy link
Contributor

github-actions bot commented Dec 4, 2023

@michael-s-molina Ephemeral environment spinning up at http://35.92.148.196:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 4, 2023
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR! I'm happy to jam with you on adding filters, spiffing up the charts, etc. if there's ever a good day to do so.

@michael-s-molina michael-s-molina merged commit 3ab27c6 into apache:master Dec 4, 2023
33 checks passed
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Ephemeral environment shutdown and build artifacts deleted.

michael-s-molina added a commit that referenced this pull request Dec 4, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigInt is throwing error when used as temporal column
4 participants