Skip to content

Commit

Permalink
chore: Clean up the examples dashboards (apache#26158)
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-s-molina authored and sfirke committed Mar 22, 2024
1 parent f02184f commit 5599ec3
Show file tree
Hide file tree
Showing 19 changed files with 659 additions and 1,314 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function prepareDashboardFilters(
},
type: 'NATIVE_FILTER',
description: '',
chartsInScope: [6],
chartsInScope: [5],
tabsInScope: [],
});
});
Expand Down Expand Up @@ -150,7 +150,7 @@ function prepareDashboardFilters(
meta: {
width: 4,
height: 50,
chartId: 6,
chartId: 5,
sliceName: 'Most Populated Countries',
},
},
Expand Down Expand Up @@ -414,7 +414,7 @@ describe('Native filters', () => {
cy.createSampleDashboards([0]);
});

it('Verify that default value is respected after revisit', () => {
it.only('Verify that default value is respected after revisit', () => {
prepareDashboardFilters([
{ name: 'country_name', column: 'country_name', datasetId: 2 },
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { TABBED_DASHBOARD } from 'cypress/utils/urls';
import { expandFilterOnLeftPanel } from './utils';

const TREEMAP = { name: 'Treemap', viz: 'treemap_v2' };
const FILTER_BOX = { name: 'Region Filter', viz: 'filter_box' };
const LINE_CHART = { name: 'Growth Rate', viz: 'line' };
const BOX_PLOT = { name: 'Box plot', viz: 'box_plot' };
const BIG_NUMBER = { name: 'Number of Girls', viz: 'big_number_total' };
Expand All @@ -41,7 +40,6 @@ function topLevelTabs() {
function resetTabs() {
topLevelTabs();
cy.get('@top-level-tabs').first().click();
waitForChartLoad(FILTER_BOX);
waitForChartLoad(TREEMAP);
waitForChartLoad(BIG_NUMBER);
waitForChartLoad(TABLE);
Expand Down Expand Up @@ -96,7 +94,6 @@ describe('Dashboard tabs', () => {

it.skip('should send new queries when tab becomes visible', () => {
// landing in first tab
waitForChartLoad(FILTER_BOX);
waitForChartLoad(TREEMAP);

getChartAliasBySpec(TREEMAP).then(treemapAlias => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { ChartSpec, waitForChartLoad } from 'cypress/utils';
export const WORLD_HEALTH_CHARTS = [
{ name: '% Rural', viz: 'world_map' },
{ name: 'Most Populated Countries', viz: 'table' },
{ name: 'Region Filter', viz: 'filter_box' },
{ name: "World's Population", viz: 'big_number' },
{ name: 'Growth Rate', viz: 'line' },
{ name: 'Rural Breakdown', viz: 'sunburst' },
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/support/e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/
import '@cypress/code-coverage/support';
import '@applitools/eyes-cypress/commands';
import failOnConsoleError, { Config } from 'cypress-fail-on-console-error';
import failOnConsoleError from 'cypress-fail-on-console-error';

require('cy-verify-downloads').addCustomCommand();

Expand Down
68 changes: 0 additions & 68 deletions superset/examples/configs/charts/Filter_Segments.yaml

This file was deleted.

53 changes: 0 additions & 53 deletions superset/examples/configs/charts/Filtering_Vaccines.yaml

This file was deleted.

47 changes: 0 additions & 47 deletions superset/examples/configs/charts/Vehicle_Sales_Filter.yaml

This file was deleted.

55 changes: 0 additions & 55 deletions superset/examples/configs/charts/Video_Game_Sales_Filter.yaml

This file was deleted.

Loading

0 comments on commit 5599ec3

Please sign in to comment.