Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releasing): adding SHA512 and RSA signature validation script to verify releases #26278

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Dec 14, 2023

SUMMARY

Validating releases to check SHA-512 checksum and RSA signature against the apache KEYS file is a bit... tedious.

This adds a python script to the RELEASING folder (and documentation about it) so you can just run the script and check if the release is valid.

Once releases contain this script, you can also run a bash script or npm script to validate the release from the scripts within.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (429e2a3) 66.99% compared to head (396d064) 69.11%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26278      +/-   ##
==========================================
+ Coverage   66.99%   69.11%   +2.11%     
==========================================
  Files        1945     1946       +1     
  Lines       75949    76437     +488     
  Branches     8460     8707     +247     
==========================================
+ Hits        50885    52830    +1945     
+ Misses      22879    21392    -1487     
- Partials     2185     2215      +30     
Flag Coverage Δ
hive 53.67% <ø> (?)
javascript 56.56% <ø> (+0.05%) ⬆️
mysql 78.08% <ø> (+0.02%) ⬆️
postgres ?
presto 53.63% <ø> (?)
python 82.79% <ø> (+4.46%) ⬆️
sqlite 76.84% <ø> (ø)
unit 55.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley changed the title feat(releasing): adding a SHA512 and feat(releasing): adding a SHA512 and RSA signature Dec 14, 2023
@rusackas rusackas changed the title feat(releasing): adding a SHA512 and RSA signature feat(releasing): adding SHA512 and RSA signature validation script to verify releases Dec 14, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 84ac72f into master Dec 18, 2023
53 checks passed
@rusackas rusackas deleted the release-validator-script branch December 18, 2023 18:47
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants