Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(sqllab): flaky json explore modal due to over-rendering (#26156)" #26284

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Dec 15, 2023

Fixes #26276

SUMMARY

This reverts commit 77c73b6.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--result-bug.mov

After:

after--render-bug.mov

TESTING INSTRUCTIONS

Go to sqllab and set async query enabled
Click on run query that takes more than 5 seconds
See the result content

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title Revert "fix(sqllab): flaky json explore modal due to over-rendering (#26156)" fix: Revert "fix(sqllab): flaky json explore modal due to over-rendering (#26156)" Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (38f5e4d) 69.18% compared to head (3669568) 69.18%.

Files Patch % Lines
...frontend/src/SqlLab/components/SouthPane/index.tsx 75.75% 3 Missing and 5 partials ⚠️
...ntend/src/SqlLab/components/QueryHistory/index.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26284      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1946     1945       -1     
  Lines       75969    75968       -1     
  Branches     8469     8467       -2     
==========================================
- Hits        52561    52558       -3     
- Misses      21222    21223       +1     
- Partials     2186     2187       +1     
Flag Coverage Δ
javascript 56.51% <76.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinpark justinpark merged commit 8450cca into apache:master Dec 15, 2023
34 of 35 checks passed
@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Dec 18, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 18, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Lab result set panel and timer disappears
3 participants