-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Ensure Mixins are ordered according to the MRO #26288
chore: Ensure Mixins are ordered according to the MRO #26288
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26288 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75968 75968
Branches 8467 8467
=======================================
Hits 52557 52557
Misses 21224 21224
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! LGTM
SUMMARY
Somewhat of a lazy Friday afternoon PR. Whilst reviewing PRs earlier today I realized there were instances where the class ordering was incorrect, i.e., the following wasn't being adhered to:
This PR ensures that, per Python's MRO the class inheritance is correctly defined. Potential problematic classes were identified by running
git grep Mixin)
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION