-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): Bump duckdb-engine version to 0.9.5 #26405
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26405 +/- ##
==========================================
- Coverage 69.14% 69.14% -0.01%
==========================================
Files 1946 1946
Lines 75990 75990
Branches 8479 8479
==========================================
- Hits 52544 52543 -1
- Misses 21267 21268 +1
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wondering if we should add an upper bound? I know you maintain the driver, so you're the best person to say if this is a valid concern or not..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit bba1b14)
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit bba1b14)
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
SUMMARY
Currently, when a user selects a DuckDB database, the schema dropdown shows multiple instances of
main
. This was an issue in the SQLAlchemy driver and has been fixed on the latest version ofduckdb_engine
.BEFORE/AFTER SCREENSHOTS
Before:
![Screenshot 2024-01-03 at 4 32 23 PM](https://private-user-images.githubusercontent.com/4041805/294058985-bf336a62-0e21-4a28-a1fd-c3a5cc3d40d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU4NDgxMzcsIm5iZiI6MTcyNTg0NzgzNywicGF0aCI6Ii80MDQxODA1LzI5NDA1ODk4NS1iZjMzNmE2Mi0wZTIxLTRhMjgtYTFmZC1jM2E1Y2MzZDQwZDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDlUMDIxMDM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODFkMjUxNmZiMThjZjU5NDdlNzBlMTQyZTA3ZGRhYjM0ODA0N2VkN2FmYjNiOTkyZmVkOGI0NGJmMWQxZGY3ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.HgIFbumQvlCxI33jxOeEq8O2V_iOdIGG5aVKbcwLQDs)
After:
![Screenshot 2024-01-03 at 4 34 02 PM](https://private-user-images.githubusercontent.com/4041805/294059124-3bf9ecb1-7d49-43c6-ad8e-b91adf2762b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU4NDgxMzcsIm5iZiI6MTcyNTg0NzgzNywicGF0aCI6Ii80MDQxODA1LzI5NDA1OTEyNC0zYmY5ZWNiMS03ZDQ5LTQzYzYtYWQ4ZS1iOTFhZGYyNzYyYjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDlUMDIxMDM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWIzNDhmODk1MGE1YTNiY2YyYTQwNTY0MTMzY2U3ZmNhODgyN2RmOTI0ZDhlZjFkZWYwNTAyMDM1MjU0YjhhZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.AZ1FP5pZPjYiaH3qGgR0_1HiJciYOs1yygynVJivt4E)
TESTING INSTRUCTIONS
db_name.schema_name
items instead of manymain
schema duplicatesADDITIONAL INFORMATION