Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): improve docker tags to be cleared and avoid conflicts #26787

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 24, 2024

Improving the docker tag naming scheme to:

  • we now suffix most tags with -arm for platofrm = linux-arm64, and leave the amd builds without suffix since they're used already, before this fix we would have conflicts between tags / images. More on this here Issue with the apache/superset:dockerize #26788
  • we now point the main dev tag (ie apache/supserset:dev, and apache/supserset:dev-arm) to top of the master branch. This tag only gets generated then.
  • on release, this should create the right top-level docker tags like apache/supserset:lean and apache/supserset:py310, ...
  • on release, the very top level for the whole repo is the lean/amd image

A question remains

Where should we point top level builds like apache/supserset:lean and apache/supserset:lean-arm or even the top-most level apache/supserset? Seems it should be pointed to the latest official ASF release version/build, unclear if it should be done in CI, or a simple docker tag command as part of the ASF release process, pointing to the image of the right SHA (that tag should be computed and exist, so all we need is to point to the right place)

Copy link

request-info bot commented Jan 24, 2024

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Jan 24, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 24, 2024
@mistercrunch mistercrunch marked this pull request as ready for review January 24, 2024 20:49
@eschutho
Copy link
Member

unclear if it should be done in CI, or a simple docker tag command as part of the ASF release process

@mistercrunch for the ASF release, the docker image creation is still handled through the CI when the sha is marked for release, so there's currently no separate or manual process that's done.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a53c537) 67.29% compared to head (8efb21f) 67.29%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26787   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files        1895     1895           
  Lines       74249    74249           
  Branches     8257     8257           
=======================================
  Hits        49968    49968           
  Misses      22206    22206           
  Partials     2075     2075           
Flag Coverage Δ
mysql 77.98% <ø> (ø)
postgres 78.08% <ø> (ø)
python 78.21% <ø> (ø)
sqlite 77.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch force-pushed the improve_docker_tags branch 3 times, most recently from 1c6199f to 7b20d29 Compare January 27, 2024 00:35
@sfirke
Copy link
Member

sfirke commented Jan 29, 2024

Note that when we talk about the dev image, its main difference from lean seems to be that it bundles the headless browser and driver needed for Alerts & Reports to work. I would like eventually to see those bundled with the main images if possible, it confuses people that they have to run an image called "dev" to get that functionality.

I'm only bringing that up here to ask that we retain functionality such that when a version is released tagged like 3.1.0, a corresponding version 3.1.0-dev is also built that contains the tools necessary for Alerts & Reports.

@sfirke sfirke removed the need:more-info Requires more information from author label Jan 29, 2024
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jan 31, 2024
@mistercrunch mistercrunch merged commit 4b77129 into master Jan 31, 2024
34 checks passed
@mistercrunch mistercrunch deleted the improve_docker_tags branch January 31, 2024 07:03
@dpgaspar dpgaspar mentioned this pull request Jan 31, 2024
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants