fix(ci): ephemeral env build #26852
Merged
fix(ci): ephemeral env build #26852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
dpgaspar
commented
Jan 29, 2024
| } | ||
| core.info(`Getting PR #${request.pull_number} from ${request.owner}/${request.repo}`) | ||
| const pr = await github.pulls.get(request); |
There was a problem hiding this comment.
To fetch the last SHA from the PR where the comment was made, more details here: actions/checkout#331
craig-rueda
approved these changes
Jan 30, 2024
geido
approved these changes
Jan 30, 2024
|
This seems stuck on the docker-build process... should we close/reopen the PR to kick-start it, or is it an actual problem with the PR? |
it's because of a defined required workflow that I'm removing here |
9 tasks
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes ephemeral envs, broken by: #26473
I'm taking the ephemeral build out of the docker/
pull_requestworkflow trigger and placing it onissue_comment.issue_commenttriggers at the issue level and uses the default branch latest SHA, this makes it hard to properly test CI workflow changes but on the other hand makes this path resilient to any possible issues caused by PRs.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION