fix(ci): lint issue on update-monorepo-lockfiles.yml #26920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
9 tasks
geido
approved these changes
Jan 31, 2024
|
@dpgaspar All other workflow files have an empty line at the end. The formatter also adds an empty line automatically. |
It looks like committed files don't have that line. LGTM. |
michael-s-molina
approved these changes
Jan 31, 2024
|
Ugh... not sure how this snuck through, but this shouldn't have been mergeable in the first place, right? |
|
Do we not re-run |
|
Oh @rusackas it's because of this -> https://github.com/apache/superset/blob/master/.github/workflows/superset-python-misc.yml#L10-L13, maybe we should run pre-commit across the board, it's pretty cheap anyways, and many checks are not python-specific anymore |
mistercrunch
added a commit
that referenced
this pull request
Jan 31, 2024
#26920 caught an issue that should have been picked up by pre-commit (by the user), but then re-caught by CI, preventing the merge. The reason is was not caught was that the CI check is part of a group of python misc checks that trigger only where the python package's folder has changed. In reality, the python utility pre-commit we use here is used for much more than just Python files, so we should run it across the repo. Here I simply factored out the check into its own GitHub Action that triggers for every single CI run.
|
Preventing this here -> #26942 |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes lint issue on
update-monorepo-lockfiles.yml, impacts open PRsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION