chore(ci): run pre-commit across the repo #26942
Merged
+54
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#26920 caught an issue that should have been picked up by pre-commit (by the user), but then re-caught by CI, preventing the merge. The reason is was not caught was that the CI check is part of a group of python misc checks that trigger only where the python package's folder has changed. In reality, the python utility pre-commit we use here is used for much more than just Python files, so we should run it across the repo. Here I simply factored out the check into its own GitHub Action that triggers for every single CI run.
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
9 tasks
rusackas
approved these changes
Jan 31, 2024
john-bodley
approved these changes
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26942 +/- ##
=======================================
Coverage 67.31% 67.31%
=======================================
Files 1895 1895
Lines 74206 74206
Branches 8219 8219
=======================================
Hits 49952 49952
Misses 22205 22205
Partials 2049 2049
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26920 caught an issue that should have been picked up by pre-commit (by the user), but then re-caught by CI, preventing the merge.
The reason is was not caught was that the CI check is part of a group of python misc checks that trigger only where the python package's folder has changed. In reality, the python utility pre-commit we use here is used for much more than just Python files, so we should run it across the repo.
Here I simply factored out the check into its own GitHub Action that triggers for every single CI run. The code block in this PR is identical/unchanged