fix(ci): new PR comments cancel ongoing ephemeral builds #27085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently ongoing ephemeral env builds can be canceled by new comments on a PR. Although the build is re-triggered again this can cause confusion and certainly delays on spinning up new ephemeral environments.
This is probably caused by the global concurrency group, splitting this group between comments and build should fix this issue.
Unfortunately it's hard to test this at the PR level since this workflow code will always use the latest commit on the default branch
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION