Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): new PR comments cancel ongoing ephemeral builds #27085

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 12, 2024

SUMMARY

Currently ongoing ephemeral env builds can be canceled by new comments on a PR. Although the build is re-triggered again this can cause confusion and certainly delays on spinning up new ephemeral environments.

This is probably caused by the global concurrency group, splitting this group between comments and build should fix this issue.

Unfortunately it's hard to test this at the PR level since this workflow code will always use the latest commit on the default branch 


BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar
Copy link
Member Author

/testenv up

@dpgaspar
Copy link
Member Author

test comment

2 similar comments
@dpgaspar
Copy link
Member Author

test comment

@kgabryje
Copy link
Member

test comment

@dpgaspar dpgaspar merged commit 16e49cb into apache:master Feb 12, 2024
29 of 30 checks passed
@dpgaspar dpgaspar deleted the fix/ephemeral-builds-concurrency branch February 12, 2024 16:59
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants