fix(ci): Docker master builds fail while checking version #27087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #27055, I broke the master builds while making the `run_cmd` method raise if it gets a non-zero exit status. Turned out to only fail while in the `pull_request` context. This is the change: https://github.com/apache/superset/pull/27055/files#diff-3cf86f687684a2c690521532de75a831def641338f5a9ec1da8add94714def4cR44-R45 This is the observed error in master build ``` Traceback (most recent call last): {...REDACTED...} File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 76, in is_latest_release output = run_cmd(f"./scripts/tag_latest_release.sh {release} --dry-run") or "" File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 45, in run_cmd raise subprocess.CalledProcessError(process.returncode, command, output) subprocess.CalledProcessError: Command './scripts/tag_latest_release.sh master --dry-run' returned non-zero exit status 1. Error: Process completed with exit code 1. ``` This disregards the exit code the `tag_latest_release.sh` since it seems to be return error codes in expected situations.
dpgaspar
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
What do you think about adding /scripts/build_docker.py to OWNERS?
https://github.com/apache/superset/blob/master/.github/CODEOWNERS
|
@dpgaspar I'll merge this buts let's look at OWNERs for all the docker-related stufff |
john-bodley
added
review:checkpoint
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #27055, I broke the master
builds while making the
run_cmdmethod raise if it gets a non-zero exitstatus. Turned out to only fail while in the
pull_requestcontext.This is the change: https://github.com/apache/superset/pull/27055/files#diff-3cf86f687684a2c690521532de75a831def641338f5a9ec1da8add94714def4cR44-R45
This is the observed error in master build
This disregards the exit code the
tag_latest_release.shsince it seemsto be return error codes in expected situations.