feat(docker): allow for docker release builds to be multi-platform #27055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
This was referenced Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27055 +/- ##
=======================================
Coverage 67.19% 67.19%
=======================================
Files 1899 1899
Lines 74380 74380
Branches 8275 8275
=======================================
+ Hits 49981 49982 +1
+ Misses 22344 22343 -1
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rusackas
approved these changes
Feb 8, 2024
Allow for release builds to be multi-platform
mistercrunch
force-pushed
the
docker_multi_platform_releases
branch
from
68cf9b0
to
71fd8c3
Compare
|
@mistercrunch 👏🏻👏🏻👏🏻👏🏻👏🏻 |
mistercrunch
added a commit
that referenced
this pull request
Feb 12, 2024
In #27055, I broke the master builds while making the `run_cmd` method raise if it gets a non-zero exit status. Turned out to only fail while in the `pull_request` context. This is the change: https://github.com/apache/superset/pull/27055/files#diff-3cf86f687684a2c690521532de75a831def641338f5a9ec1da8add94714def4cR44-R45 This is the observed error in master build ``` Traceback (most recent call last): {...REDACTED...} File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 76, in is_latest_release output = run_cmd(f"./scripts/tag_latest_release.sh {release} --dry-run") or "" File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 45, in run_cmd raise subprocess.CalledProcessError(process.returncode, command, output) subprocess.CalledProcessError: Command './scripts/tag_latest_release.sh master --dry-run' returned non-zero exit status 1. Error: Process completed with exit code 1. ``` This disregards the exit code the `tag_latest_release.sh` since it seems to be return error codes in expected situations.
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow for release builds to be multi-platform
This PR:
scripts/build_docker.pyCLI.github/workflows/docker-release.ymltobuild multi-platform images that can be used in helm or docker-compose
closes #27043
Testing / validation
Testing using the
workflow_dispatchhere -> https://github.com/apache/superset/actions/runs/7835882887/job/21382286370Validated the images look ok on Docker hub ->
