Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): un-bumping dom-to-pdf ro resolve missing file warnings #27091

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Feb 12, 2024

SUMMARY

For some reason, a bump of this package seemed to cause these annoying errors
image

Taking it back down one patch version seems to resolve them :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@rusackas rusackas marked this pull request as ready for review February 12, 2024 21:03
@fisjac
Copy link
Contributor

fisjac commented Feb 12, 2024

linking associated issue: #27089

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8e208d) 67.17% compared to head (e1ca6ec) 67.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27091   +/-   ##
=======================================
  Coverage   67.17%   67.18%           
=======================================
  Files        1900     1900           
  Lines       74443    74443           
  Branches     8293     8293           
=======================================
+ Hits        50009    50012    +3     
+ Misses      22379    22376    -3     
  Partials     2055     2055           
Flag Coverage Δ
javascript 56.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit 884ea03 into master Feb 12, 2024
34 of 56 checks passed
@rusackas rusackas deleted the de-bump-dom-to-pdf branch February 12, 2024 23:13
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants