Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Only fetch CSS templates for dashboard header menu when in edit mode #27411

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix(dashboard): Only fetch CSS templates for dashboard header menu when in edit mode #27411

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85e2080
fix: Only fetch CSS templates when in edit mode
mskelton Mar 6, 2024
e9b7e47
fix: Move CSS template loading into the CSS editor
mskelton Mar 6, 2024
75703ef
Fixes test
michael-s-molina Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,20 +110,22 @@
}

UNSAFE_componentWillMount() {
SupersetClient.get({ endpoint: '/csstemplateasyncmodelview/api/read' })
.then(({ json }) => {
const cssTemplates = json.result.map(row => ({
value: row.template_name,
css: row.css,
label: row.template_name,
}));
this.setState({ cssTemplates });
})
.catch(() => {
this.props.addDangerToast(
t('An error occurred while fetching available CSS templates'),
);
});
if (this.props.editMode) {
SupersetClient.get({ endpoint: '/csstemplateasyncmodelview/api/read' })
.then(({ json }) => {
const cssTemplates = json.result.map(row => ({
value: row.template_name,
css: row.css,
label: row.template_name,
}));
this.setState({ cssTemplates });

Check warning on line 121 in superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

View check run for this annotation

Codecov / codecov/patch

superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx#L121 

Added line #L121 was not covered by tests
})
.catch(() => {
this.props.addDangerToast(
t('An error occurred while fetching available CSS templates'),
);
});
}
}

UNSAFE_componentWillReceiveProps(nextProps) {
Expand Down
Loading