-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dbview): Add token request button to DuckDB and MotherDuck database modal #27908
Merged
betodealmeida
merged 19 commits into
apache:master
from
guenp:guenp/add-token-request-button
Apr 15, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cf18d92
Add database and motherduck_token fields
guenp f6f0d06
add a button to get token
guenp 7a00c51
add MDURI class, use instead of URL class
guenp a752454
sqlalchemy uri should be str, database not required, make_url_safe re…
guenp f3cd6cf
indentation
guenp 9c86708
remove unused code
guenp 9b77d30
move hard-coded url to duckdb engine spec
guenp 6c53983
dynamically set link text from parameters via description
guenp 05cd528
Update superset/databases/utils.py
guenp d68f049
Update superset/db_engine_specs/duckdb.py
guenp 0542c58
refactor sqlalchemy uri build and remove unused code
guenp 3763eef
formatting
guenp 403111c
set token to empty string by default
guenp 8829806
throw error if no token is provided for motherduck engine
guenp 2663e61
formatting
guenp 6430dd2
add UTs, return :memory: as default db for duckdb engine
guenp 9eebe83
use the Superset default button instead of bare antd version
guenp 31736a3
set parameters to empty dict if None
guenp 836cd7f
add docstrings
guenp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self, we should not require this, it's the same for every database.