chore: Add custom keywords for SQL Lab autocomplete #28153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
requested review from
betodealmeida,
john-bodley,
eschutho and
michael-s-molina
john-bodley
changed the title
Comment on lines
180
to
181
| docHTML?: string | undefined; | ||
| docText?: string | undefined; |
There was a problem hiding this comment.
Suggested change
| docHTML?: string | undefined; | |
| docText?: string | undefined; | |
| docHTML?: string; | |
| docText?: string; |
| export function useKeywords( | ||
| { queryEditorId, dbId, schema }: Params, | ||
| skip = false, | ||
| ) { | ||
| const useCustomKeywords = |
There was a problem hiding this comment.
Can we instantiate customKeywords as an empty array that is overridden when sqleditor.extension.customAutocomplete is defined?
michael-s-molina
approved these changes
Apr 24, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This commit includes the addition of
sqleditor.extension.customAutocompleteto the extension registry, which allows for the utilization of custom keywords in SQL Lab autocomplete.TESTING INSTRUCTIONS
specs
ADDITIONAL INFORMATION