Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): unable to resize due to the overlapped droptarget #28772

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(dashboard): unable to resize due to the overlapped droptarget #28772

merged 1 commit into from
May 30, 2024
+7 −7

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the resizing issues on last item in #28746 and #28395 by applying the inset location only while dragging.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

ChartResize-ezgif com-optimize (1)

After:

after--dropzone.mov

TESTING INSTRUCTIONS

Extend a widget to the entire width, then resize it again to narrow it down.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard Namespace | Anything related to the Dashboard labels May 29, 2024
@justinpark justinpark force-pushed the hotfix--unable-resize-due-to-inset-dropzone branch from e53c6ac to 9ffa172 Compare May 29, 2024 23:42
@michael-s-molina
Copy link
Member

@rtexelm

@justinpark justinpark force-pushed the hotfix--unable-resize-due-to-inset-dropzone branch from 9ffa172 to 6296211 Compare May 30, 2024 17:55
@justinpark
Copy link
Member Author

@rtexelm could you help this code review?

rtexelm
rtexelm approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@rtexelm rtexelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is definitely more appropriate. LGTM

@justinpark justinpark merged commit ce568c3 into apache:master May 30, 2024
31 checks passed
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@justinpark @EnxDev
fix(dashboard): unable to resize due to the overlapped droptarget (ap…
58d4af3 
…ache#28772)
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 4, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 5, 2024
@justinpark @michael-s-molina
fix(dashboard): unable to resize due to the overlapped droptarget (#2…
38fdf23 
…8772)

(cherry picked from commit ce568c3)
eschutho pushed a commit that referenced this pull request Jun 23, 2024
@justinpark @sadpandajoe
fix(dashboard): unable to resize due to the overlapped droptarget (#2…
0a9d7f4 
…8772)

(cherry picked from commit ce568c3)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rtexelm rtexelm rtexelm approved these changes

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend dashboard Namespace | Anything related to the Dashboard size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinpark @michael-s-molina @rtexelm @mistercrunch