-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): sync Jest version across plugins #29414
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
…mplate Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@@ -12,7 +12,7 @@ | |||
"@airbnb/config-babel": "^2.0.1", | |||
"@babel/cli": "^7.16.0", | |||
"@types/jest": "^26.0.4", | |||
"jest": "^26.6.3", | |||
"jest": "^29.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is a good opportunity to make Jest a peer dependency and also use *
as the version because we want future bumps of Jest to also be applicable to plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if specifying Jest as peerDeps would be correct since the library is used for development only and for the plugin's operations. If there's anything akin to peerDevDependencies
, it'd be more suitable :D
I mean, yeah, it'll be super satisfying for a single future Jest/Storybook/Babel bump to impact all plugins but I feel it's a little bit trading off correction for convenience. I'm not sure how to articulate this point, tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's anything akin to peerDevDependencies, it'd be more suitable :D
Yeah, that would be the ideal solution. I believe that with current limitations, correction beats convenience so you can ignore my suggestion.
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hi there folks, is this PR merge-able? Anything I need to do to proceed forward? 👀 |
Signed-off-by: hainenber <dotronghai96@gmail.com>
chore(build): sync Jest version across plugins
SUMMARY
I noticed a newly added plugin still use old Jest version v26 versus current one of v29. This PR is to rectify that and to ensure generated plugin in future will have Jest v29 as dev deps.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
All CI checks pass
ADDITIONAL INFORMATION